Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo #3200

Merged
merged 1 commit into from
Jun 7, 2024
Merged

fix typo #3200

merged 1 commit into from
Jun 7, 2024

Conversation

sudhackar
Copy link
Contributor

@sudhackar sudhackar commented Jun 7, 2024

a simple typo. This came up from a coverity scan - while processing the Main Inclusion Review(MIR) of python-botocore package

tests/unit/test_args.py:189:17:
  remediation: Should identifier "enpoint_url" be replaced by "endpoint_url"?
botocore/args.py:305:55: Supporting evidence set 1:
  identifier_use: Example 1: Using identifier "endpoint_url".
botocore/client.py:1102:28: Supporting evidence set 2:
  identifier_use: Example 2: Using identifier "endpoint_url".
botocore/configprovider.py:1010:40: Supporting evidence set 3:
  identifier_use: Example 3: Using identifier "endpoint_url".
botocore/session.py:1061:26: Supporting evidence set 4:
  identifier_use: Example 4: Using identifier "endpoint_url".
botocore/utils.py:2017:29: Supporting evidence set 5:
  identifier_use: Example 5: Using identifier "endpoint_url".

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.14%. Comparing base (f563963) to head (c277147).
Report is 20 commits behind head on develop.

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3200   +/-   ##
========================================
  Coverage    93.14%   93.14%           
========================================
  Files           66       66           
  Lines        14248    14248           
========================================
  Hits         13272    13272           
  Misses         976      976           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@nateprewitt nateprewitt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good find, thanks @sudhackar!

@nateprewitt nateprewitt merged commit 518d1b0 into boto:develop Jun 7, 2024
34 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Jun 7, 2024
* release-1.34.122:
  Bumping version to 1.34.122
  Update endpoints model
  Update to latest models
  fix typo (#3200)
hswong3i pushed a commit to alvistack/boto-botocore that referenced this pull request Jun 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants