Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Request/Response Checksum Behavior Updates #3277

Open
wants to merge 24 commits into
base: flexible-checksums-v2
Choose a base branch
from
Open

Request/Response Checksum Behavior Updates #3277

wants to merge 24 commits into from

Commits on Nov 1, 2024

  1. Add Flexible Checksum v2 Config Options (boto#3271) 

    Add ``request_checksum_calculation`` and ``response_checksum_validation`` config options.
    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    cdcb6b0 View commit details
    Browse the repository at this point in the history

  2. Add support for CRC64NVME when the CRT is available. (boto#3273) 

    * Add support for CRC64NVME when the CRT is available.

* Update crc64nvme priority
    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    c38b116 View commit details
    Browse the repository at this point in the history

  3. Make CRC32 the default checksum and remove MD5

    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    02fac6d View commit details
    Browse the repository at this point in the history

  4. Add tests for

    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    50d7142 View commit details
    Browse the repository at this point in the history

  5. Fix CRT only tests

    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    0a2971f View commit details
    Browse the repository at this point in the history

  6. Actually fix CRT only tests

    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    bf16ed7 View commit details
    Browse the repository at this point in the history

  7. PR Feedback

    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    88eb03b View commit details
    Browse the repository at this point in the history

  8. Ignore x-amz-checksum-algorithm when checking for user supplied check… 

    …sums.
    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    878cb93 View commit details
    Browse the repository at this point in the history

  9. Revert "Ignore x-amz-checksum-algorithm when checking for user suppli… 

    …ed checksums."

This reverts commit 93a47eb.
    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    7563334 View commit details
    Browse the repository at this point in the history

  10. enable response checksum validation by default

    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    860dc3b View commit details
    Browse the repository at this point in the history

  11. PR feedback

    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    2e24f7f View commit details
    Browse the repository at this point in the history

  12. Condense conditional; Update private function warning to docstring

    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    e9eade8 View commit details
    Browse the repository at this point in the history

  13. Avoid importing _CHECKSUM_CLS directly.

    @jonathan343
    jonathan343 committed Nov 1, 2024
    Configuration menu
    Copy the full SHA
    ce46e4a View commit details
    Browse the repository at this point in the history

Commits on Nov 6, 2024

  1. Add Flexible Checksum v2 Config Options (boto#3271) 

    Add ``request_checksum_calculation`` and ``response_checksum_validation`` config options.
    @jonathan343
    jonathan343 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    d44bb57 View commit details
    Browse the repository at this point in the history

  2. Add support for CRC64NVME when the CRT is available. (boto#3273) 

    * Add support for CRC64NVME when the CRT is available.

* Update crc64nvme priority
    @jonathan343
    jonathan343 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    dc710ec View commit details
    Browse the repository at this point in the history

  3. merge flexible-checksums-v2

    @jonathan343
    jonathan343 committed Nov 6, 2024
    Configuration menu
    Copy the full SHA
    0569615 View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2024

  1. merge flexible-checksums-v2

    @jonathan343
    jonathan343 committed Nov 13, 2024
    Configuration menu
    Copy the full SHA
    626c08a View commit details
    Browse the repository at this point in the history

Commits on Nov 20, 2024

  1. Make "handle_request_validation_mode_member" private.

    @jonathan343
    jonathan343 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    8f26df1 View commit details
    Browse the repository at this point in the history

  2. Set the header targeted by the "requestAlgorithmMember" to the defaul… 

    …t checksum algorithm.
    @jonathan343
    jonathan343 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    253928d View commit details
    Browse the repository at this point in the history

  3. Minor test cleanup changes.

    @jonathan343
    jonathan343 committed Nov 20, 2024
    Configuration menu
    Copy the full SHA
    ff4f122 View commit details
    Browse the repository at this point in the history

Commits on Nov 21, 2024

  1. Resolve the "requestAlgorithmMember" header in "apply_request_checksum".

    @jonathan343
    jonathan343 committed Nov 21, 2024
    Configuration menu
    Copy the full SHA
    a2b19bd View commit details
    Browse the repository at this point in the history

Commits on Nov 22, 2024

  1. PR Feedback - Make requestAlgorithmMember context more specific.

    @jonathan343
    jonathan343 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    503ead6 View commit details
    Browse the repository at this point in the history

  2. fix testing issue; Assert actual checksum values in tests.

    @jonathan343
    jonathan343 committed Nov 22, 2024
    Configuration menu
    Copy the full SHA
    509440a View commit details
    Browse the repository at this point in the history

Commits on Nov 25, 2024

  1. Handle unsigned and "s3" signature_version requests.

    @jonathan343
    jonathan343 committed Nov 25, 2024
    Configuration menu
    Copy the full SHA
    43ba7d0 View commit details
    Browse the repository at this point in the history