Update broken Polly example #3300
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## develop #3300 +/- ##
========================================
Coverage 93.18% 93.18%
========================================
Files 66 66
Lines 14345 14375 +30
========================================
+ Hits 13367 13396 +29
- Misses 978 979 +1 ☔ View full report in Codecov by Sentry. |
aws-sdk-python-automation
added a commit
that referenced
this pull request
Nov 18, 2024
* release-1.35.64: Bumping version to 1.35.64 Update to latest models Merge customizations for Customer Profiles Update Inaccurate Polly example (#3300) Bump codecov/codecov-action from 4.6.0 to 5.0.2
hswong3i
pushed a commit
to alvistack/boto-botocore
that referenced
this pull request
Nov 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Boto3 #4920
The examples in Polly's docs is misleading; the current suggested input is for content is
file://example.pls, but that will cause the literal string offile://example.plsto be uploaded as the content, resulting in the following error:Polly expects this input to be a lexicon as defined by the PLS specificiation. This PR is to make it clearer that we will not open and retrieve the file contents on behalf of the customer, and that they must provide the contents of the pls directly.