Add pciutils to packages in release #142
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ytsssun
approved these changes
Sep 10, 2024
packages/pciutils/Cargo.toml
Outdated
| path = "../packages.rs" | ||
|
|
||
| [package.metadata.build-package] | ||
| releases-url = "https://mj.ucw.cz/download/linux/pci/" |
There was a problem hiding this comment.
Nit: pciutils is also available at https://www.kernel.org/pub/software/utils/pciutils/. Should we use that for consistency? We have a good number of packages that consume from kernel.org.
There was a problem hiding this comment.
Good catch, I had switched in the spec file and not here.
yeazelm
force-pushed
the
pciutils
branch
3 times, most recently
from
6257a42
to
21fedf6
Compare
ytsssun
approved these changes
Sep 11, 2024
bcressey
reviewed
Sep 11, 2024
packages/pciutils/pciutils.spec
Outdated
Comment on lines
1
to
2
| %global debug_package %{nil} | ||
| %global __strip %{_bindir}/true |
There was a problem hiding this comment.
We shouldn't need these.
Suggested change
| %global debug_package %{nil} | |
| %global __strip %{_bindir}/true |
There was a problem hiding this comment.
Nice call! I added these when trying things but they are not needed!
This adds the pciutils package to the release package dependencies so that lspci is available for debugging devices on Bottlerocket images. Signed-off-by: Matthew Yeazel <[email protected]>
|
^ removed extra lines per comments. |
bcressey
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
This adds the
pciutilspackage to the release package dependencies so that lspci is available for debugging devices on Bottlerocket images.Testing done:
Booted an image and checked
lspciworks on x86_64 and aarch64aarch t4g.large
NVIDIA x86_64
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.