kmod-5.10-nvidia: move to R535 branch from R470 #181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yeazelm
force-pushed
the
470_to_535
branch
2 times, most recently
from
1c4c81f
to
b9e9915
Compare
|
^ push to rebase on |
|
^ removes the additional Provides which will be handled in a major version bump due to the breaking change for 5.10 kernel variants using this kmod. |
The R470 branch is end of life. In order to keep variants using the 5.10 kernel on a supported NVIDIA driver, this commit moves the kmod package for 5.10 to build the R535 branch and brings the driver in line with the other two kernel kmod packages in packaging style. Signed-off-by: Matthew Yeazel <[email protected]>
|
^ Remove nvidia-tesla-tmpfiles.conf.in which no longer needed for this package. |
bcressey
approved these changes
Oct 11, 2024
arnaldo2792
approved these changes
Oct 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes # bottlerocket-os/bottlerocket#4220
Description of changes:
The R470 branch is end of life. In order to keep variants using the 5.10 kernel on a supported NVIDIA driver, this commit moves the kmod package for 5.10 to build the R535 branch and brings the driver in line with the other two kernel kmod packages in packaging style.
Note that the only difference between the spec and package configuration of
kmod-5.10-nvidiaand the other kmod-*-nvidia packages is an additionalProvides:Provides: %{name}-tesla-470so that current variants depending on this will get this R535 version instead. This change moves the naming of the package from kmod-5.10-nvidia-tesla-470 -> kmod-5.10-nvidia-tesla-535 which is depended upon directly at https://github.com/bottlerocket-os/bottlerocket/blob/develop/variants/aws-ecs-1-nvidia/Cargo.toml#L33Testing done:
Built aws-k8s-1.23-nvidia with the changes and validated that the driver is using R535 on 5.10:
Built aws-ecs-1-nvidia with the changes and validated that the driver is using R535 and 5.10:
Ran gpu smoke tests to confirm its working on aws-ecs-1-nvidia:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.