diff-kernel-config: fix for core-kits #32
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
larvacea
approved these changes
Jul 13, 2024
koooosh
requested changes
Jul 13, 2024
tools/diff-kernel-config
Outdated
| @@ -114,6 +101,7 @@ readonly output_dir | |||
| # checkout. | |||
| [[ -n ${gitrev_before_arg} ]] || usage_error 'require -b|--before' | |||
| [[ -n ${gitrev_after_arg} ]] || usage_error 'require -a|--after' | |||
| [[ -n ${kernel_versions[@]} ]] || usage_error 'require -k|--kernel' | |||
There was a problem hiding this comment.
Builds are failing with this error:
diff-kernel-config:104:7: error: Arrays implicitly concatenate in [[ ]]. Use a loop (or explicit * instead of @). [SC2199]
I believe this line is the culprit. Ways to fix this: https://www.shellcheck.net/wiki/SC2199
The script referenced variants, which aren't a thing in the core-kit world Signed-off-by: Arnaldo Garcia Rincon <[email protected]>
arnaldo2792
force-pushed
the
fix-diff-kernel-script
branch
from
1a38550
to
08e37cb
Compare
|
Forced push includes fixes for shellchecks |
ginglis13
approved these changes
Jul 16, 2024
yeazelm
approved these changes
Jul 16, 2024
koooosh
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
N / A
Description of changes:
The script referenced variants, which aren't a thing in the core-kit world
Testing done:
I ran the script with the changes in: #29 , and the report was generated:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.