-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kit changes for Nvidia settings APIs #48
Merged
monirul
merged 1 commit into
bottlerocket-os:develop
from
monirul:nvidia-api-kit-changes
Aug 1, 2024
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
14 changes: 14 additions & 0 deletions
14
packages/nvidia-container-toolkit/nvidia-container-toolkit-config-k8s
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,14 @@ | ||
| [required-extensions] | ||
| nvidia-container-runtime = "v1" | ||
| std = { version = "v1", helpers = ["default"] } | ||
|
|
||
| +++ | ||
| ### generated from the template file ### | ||
| accept-nvidia-visible-devices-as-volume-mounts = {{default true settings.nvidia-container-runtime.visible-devices-as-volume-mounts}} | ||
| accept-nvidia-visible-devices-envvar-when-unprivileged = {{default false settings.nvidia-container-runtime.visible-devices-envvar-when-unprivileged}} | ||
|
|
||
| [nvidia-container-cli] | ||
| root = "/" | ||
| path = "/usr/bin/nvidia-container-cli" | ||
| environment = [] | ||
| ldconfig = "@/sbin/ldconfig" |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 changes: 13 additions & 0 deletions
13
packages/nvidia-k8s-device-plugin/nvidia-k8s-device-plugin-conf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| [required-extensions] | ||
| kubernetes = "v1" | ||
| std = { version = "v1", helpers = ["default"] } | ||
|
|
||
| +++ | ||
| version: v1 | ||
| flags: | ||
| migStrategy: "none" | ||
| failOnInitError: true | ||
| plugin: | ||
| passDeviceSpecs: {{default true settings.kubernetes.device-plugins.nvidia.pass-device-specs}} | ||
| deviceListStrategy: {{default "volume-mounts" settings.kubernetes.device-plugins.nvidia.device-list-strategy}} | ||
| deviceIDStrategy: {{default "index" settings.kubernetes.device-plugins.nvidia.device-id-strategy}} |
8 changes: 8 additions & 0 deletions
8
packages/nvidia-k8s-device-plugin/nvidia-k8s-device-plugin-exec-start-conf
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,8 @@ | ||
| [required-extensions] | ||
| kubernetes = "v1" | ||
| +++ | ||
| [Service] | ||
| {{#if settings.kubernetes.device-plugins.nvidia}} | ||
| ExecStart= | ||
| ExecStart=/usr/bin/nvidia-device-plugin --config-file=/etc/nvidia-k8s-device-plugin/settings.yaml | ||
| {{/if}} | ||
2 changes: 0 additions & 2 deletions
2
packages/nvidia-k8s-device-plugin/nvidia-k8s-device-plugin.service
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you test that this works correctly on instances without an nvidia device plugin set?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes. I tested it if
settings.kubernetes.device-plugins.nvidiais not defined then this file is rendered aswhich are kind of ignored as there is no overriding settings. It works as expected.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This feels weird and to someone just seeing this on the system would appear to be a failure? Can we add a comment in an else statement to say deliberately left this way or something? Is it not better to just remove the
[Service]as well?