support hostname-override-source #59
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tzneal
force-pushed
the
add-hostname-override-source
branch
from
966b7fe
to
9d7f90b
Compare
bcressey
approved these changes
Jul 30, 2024
tzneal
force-pushed
the
add-hostname-override-source
branch
from
9d7f90b
to
d3a75f5
Compare
bcressey
approved these changes
Jul 31, 2024
Comment on lines
+387
to
+389
| KubernetesHostnameOverrideSource::InstanceID => { | ||
| aws_k8s_info.hostname_override = Some(instance_id); | ||
| } |
There was a problem hiding this comment.
nit: it'd be slightly better to fetch the instance ID within this block, as otherwise we pay for the cost of an IMDS interaction and end up throwing away the result when using the private DNS source
There was a problem hiding this comment.
We use it both places, in the private DNS lookup we filter by the instance ID so we only get the single response.
ginglis13
approved these changes
Jul 31, 2024
cbgbt
approved these changes
Jul 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue number:
Closes #
Description of changes:
Supports the new hostname-override-source setting to we can use the instance-id as the node name with K8s.
Testing done:
Built & verified that the following AMIs launched and joined the cluster with the correct node name for the following scenarios:
1.23 - No userdata
1.29 - No userdata
1.29 - hostname-override-source = private-dns-name
1.29 - hostname-override-source = instance-id
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.