-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kit changes for Bootstrap Commands #62
Conversation
cecd88e
to
b8b8dcd
Compare
32249c5
to
1af1cae
Compare
c50bda9
to
d0fcf03
Compare
737bde6
to
a4a72e2
Compare
I figured out the encoding bit. Apparently handlebars HTML-encodes data by default with the "double-stache". If you "triple-stache", it embeds it directly. |
905f136
to
6fc04f4
Compare
8d28192
to
32b7b73
Compare
bd88c26
to
1cf0639
Compare
Forced push addresses the following:
|
3a3bed4
to
f438f12
Compare
Forced push addresses the following:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work! It's probably worth documenting how reboots are handled -- that might be best on the website.
fn iter(self) -> impl Iterator<Item = (Identifier, BootstrapCommand)> { | ||
self.bootstrap_commands.into_iter() | ||
} | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is fine, but as a Rust tip, there's the IntoIter
in std
that you can implement for this behavior, which can make calling other APIs that expect IntoIter
ergonomic.
forced push removes the hack commit to use the official settings-sdk |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice job! 🎉
Issue number:
Closes #
Description of changes:
This PR contains core-kit changes to add
bootstrap-commands
. The relevant settings-sdk changes are in PR 46Testing done:
Test case 1: 2 bootstrap commands
first boot sets
motd
tohelloworld3
second boot sets
motd
tohelloworld1
Test case 2: No bootstrap commands
No boot issues.
Note:
3 files have been modified to build successfully. "sources/api/Cargo.toml", "sources/deny.toml", "sources/Cargo.lock". These are dependent on the settings-sdk changes in PR 46. They will be reverted back at the end of code review.
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.