Use bottlerocket-settings-sdk for settings models needed in core-kit #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcressey
approved these changes
Jun 19, 2024
sam-berning
approved these changes
Jun 19, 2024
| @@ -1571,7 +1573,7 @@ impl Runtime { | |||
| fn get_resource_limits( | |||
| &self, | |||
| rlimit_type: &OciDefaultsResourceLimitType, | |||
| values: &OciDefaultsResourceLimit, | |||
| values: &OciDefaultsResourceLimitV1, | |||
There was a problem hiding this comment.
I think it's ok to use the setting extension's model for now, but long term these helpers should live with the setting extension right?
There was a problem hiding this comment.
Yes. The settings extension API provides a mechanism for exposing these helpers, so the helper code would move to the owning extension.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Some software in Bottlerocket uses
modeled-typesshared by Bottlerocket's settings models. These types now have a home in https://github.com/bottlerocket-os/bottlerocket-settings-sdk. This change moves core-kit to refer to the settings SDK for shared types.Testing done:
Terms of contribution:
By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.