Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cross: install golang in the cross container #399

Merged
merged 2 commits into from
Oct 11, 2024

Conversation

cbgbt
Copy link
Contributor

@cbgbt cbgbt commented Oct 11, 2024

Description of changes:
Twoliter's release process has been failing, as the build of krane has been unable to locate the go compiler. This was because Twoliter's release build is done by cargo-cross, which takes advantage of a containerized build environment with the appropriate cross-compilation toolchain for each target.

This ensures the cross environment also contains a go compiler and configures it to be usable by the krane-bundle crate build.

Testing done:

  • Performed a release in my fork of Twoliter here.

Terms of contribution:

By submitting this pull request, I agree that this contribution is dual-licensed under the terms of both the Apache License, version 2.0, and the MIT license.

@cbgbt cbgbt merged commit 929a517 into bottlerocket-os:develop Oct 11, 2024
1 check passed
@cbgbt cbgbt deleted the cross-build-with-golang branch October 11, 2024 19:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants