Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Gamescope options arguments #3217

Merged
merged 1 commit into from
Mar 3, 2024
Merged

Conversation

SuperSamus
Copy link
Contributor

Description

Partially split off from #2840, since that is stalled (it will need to be rebased later).

Fixes #3065, fixes #3195.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Not really tested, tbh.

Copy link

fab-sonarqube bot commented Dec 25, 2023

Copy link
Contributor

github-actions bot commented Dec 25, 2023

Pylint result on modfied files:
************* Module bottles.backend.wine.winecommand
bottles/backend/wine/winecommand.py:90:4: W0102: Dangerous default value {} as argument (dangerous-default-value)
bottles/backend/wine/winecommand.py:90:4: R0913: Too many arguments (11/5) (too-many-arguments)
bottles/backend/wine/winecommand.py:135:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:141:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:397:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:401:51: E1136: Value 'gpu['prime']['integrated']' is unsubscriptable (unsubscriptable-object)
bottles/backend/wine/winecommand.py:403:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:182:8: W0612: Unused variable 'is_nvidia' (unused-variable)
bottles/backend/wine/winecommand.py:449:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:458:12: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:474:4: R0913: Too many arguments (6/5) (too-many-arguments)
bottles/backend/wine/winecommand.py:509:32: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/wine/winecommand.py:518:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/wine/winecommand.py:527:21: W1514: Using open without explicitly specifying an encoding (unspecified-encoding)
bottles/backend/wine/winecommand.py:543:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:548:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:553:20: W0105: String statement has no effect (pointless-string-statement)
bottles/backend/wine/winecommand.py:646:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/wine/winecommand.py:657:8: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)
bottles/backend/wine/winecommand.py:695:12: R1705: Unnecessary "else" after "return", remove the "else" and de-indent the code inside it (no-else-return)
bottles/backend/wine/winecommand.py:716:23: R1732: Consider using 'with' for resource-allocating operations (consider-using-with)

@svin24
Copy link

svin24 commented Jan 26, 2024

I can say that on my PR( #3262 which is essentially the same code), this works as I have tested it.

Copy link

fab-sonarqube bot commented Feb 24, 2024

@mirkobrombin mirkobrombin merged commit 3c7b933 into bottlesdevs:main Mar 3, 2024
6 checks passed
@SuperSamus SuperSamus deleted the patch-3 branch March 3, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants