fix(project): specify the corrent gettext domain in appstream file #3261
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The gettext text domain used in the application and the one which Meson installs to is
bottles
, but the one specified in the appstream file iscom.usebottles.bottles
Bottles/bottles/frontend/bottles.py
Line 36 in ed765a9
Bottles/bottles/frontend/main.py
Lines 67 to 70 in ed765a9
Bottles/data/com.usebottles.bottles.gschema.xml
Line 2 in ed765a9
Bottles/po/meson.build
Line 12 in ed765a9
Bottles/data/com.usebottles.bottles.metainfo.xml.in
Line 49 in ed765a9
Also, should I instead change the gettext domain to
com.usebottles.bottles
in the application and Meson? I think it is best practice, but it might break the Weblate bot or something.Type of change
How Has This Been Tested?
Never tested. I don't know how I can test it.