Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(project): specify the corrent gettext domain in appstream file #3261

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

zefr0x
Copy link

@zefr0x zefr0x commented Jan 24, 2024

Description

The gettext text domain used in the application and the one which Meson installs to is bottles, but the one specified in the appstream file is com.usebottles.bottles

gettext.install('bottles', localedir)

locale.bindtextdomain("bottles", locale_dir)
locale.textdomain("bottles")
gettext.bindtextdomain("bottles", locale_dir)
gettext.textdomain("bottles")

<schemalist gettext-domain="bottles">

'bottles',

<translation type="gettext">com.usebottles.bottles</translation>


Also, should I instead change the gettext domain to com.usebottles.bottles in the application and Meson? I think it is best practice, but it might break the Weblate bot or something.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Never tested. I don't know how I can test it.

Copy link

fab-sonarqube bot commented Feb 23, 2024

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant