Recipients controller & spec #67
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fosome
commented
Jan 9, 2017
| @@ -0,0 +1,36 @@ | |||
| class RegionAdmin::RecipientsController < ApplicationController | |||
There was a problem hiding this comment.
Got rails g'd again - updating module definition.
Fosome
force-pushed
the
rf/recipients-controller-spec
branch
from
d72ec19 to
03ffdea
Compare
Fosome
force-pushed
the
rf/recipients-controller-spec
branch
2 times, most recently
from
d72fe83 to
e473135
Compare
ericfreese
reviewed
Jan 24, 2017
| @@ -95,7 +95,7 @@ | |||
|
|
|||
| <%= drop_down "Region Admin" do %> | |||
| <%= menu_item "Donors", region_admin_donors_url %> | |||
| <%= menu_item "Recipients", recipients_locations_path %> | |||
| <%= menu_item "Recipients", region_admin_recipients_url %> | |||
There was a problem hiding this comment.
Why the change from _path to _url here?
There was a problem hiding this comment.
The real change is adding the region_admin prefix. I switched the _path to _url as a matter of preference
ericfreese
reviewed
Jan 24, 2017
| <% end %> | ||
| <%= link_to "Edit", edit_location_url(location) %><br> | ||
| <%= link_to "Delete", location_url(location), :confirm => "Are you sure?", :method => :delete %> | ||
| </td> |
There was a problem hiding this comment.
It looks like this view is missing a few table columns that were originally shown when this list was rendered with locations/index.html.erb. Was this intentional?
There was a problem hiding this comment.
It was intentional - there were too many fields in a row. All the data is visible on the #show page.
Fosome
force-pushed
the
rf/recipients-controller-spec
branch
from
e473135 to
ab7e135
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Move recipients index out to
region_adminnamespace, separate controller.Add integration test.
Related to efforts #53 #62