Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taking arbitrary params in Direct connectable strings #1459

Conversation

adwait-godbole
Copy link
Contributor

@adwait-godbole adwait-godbole commented Aug 16, 2024

@Julian I have probably failed miserably at this :( but yeah here’s something atleast.


📚 Documentation preview 📚: https://bowtie-json-schema--1459.org.readthedocs.build/en/1459/

@adwait-godbole
Copy link
Contributor Author

The tests are failing because now everytime make_connect creates a new lambda callable so the the object addresses are not the same while comparing.

@Julian
Copy link
Member

Julian commented Aug 21, 2024

This indeed turned out to be less straightforward than I implied, basically because to solve the problem you mentioned (about equality of lambda functions) requires inserting an additional type. You were certainly on the right track! So props for that. You can see what I did for this in 7ea8c30 -- which still can be improved, but hopefully unblocks this. Thanks again for giving these kinds of things a real shot, well done!

@Julian Julian closed this Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants