fix(content-sidebar): box ai sidebar zoom fix #3809
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kkuliczkowski-box
force-pushed
the
content-sidebar/fix-box-ai-zoom
branch
from
d261ecc to
a92faeb
Compare
m-dudek
reviewed
Dec 27, 2024
| @@ -4,60 +4,52 @@ | |||
|
|
|||
There was a problem hiding this comment.
Hi Kamil,
A clarification question:
- Instead of defining media query here you leverage media query created for the whole sidebar (here) by appending the bcs-is-wider class?
There was a problem hiding this comment.
Not really. Media query block was not needed after a small refactor I've done by not setting the Box AI Sidebar width to a fixed number ($sidebarContentIncreasedWidth). It's now using the entire available width in both scenarios.
And the addition of .bcs-is-wider was required to get a higher specificity for some of the selectors. We're safe to add it because bcs-is-wider will always be present when Box AI Sidebar is visible.
karolinaru
approved these changes
Dec 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed the styling of Box AI Sidebar when zoomed in >= 175%. Previously a horizontal scroll was appearing at the bottom.
Before:
After:
Mobile view looks the same as before:
