Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(boxai-sidebar): Fix typo in avatarURL name #3810

Merged
merged 5 commits into from
Jan 2, 2025

Conversation

jankowiakdawid
Copy link
Contributor

Fixes the issue with Avatar image not showing when asking a question in AI Sidebar.

Before
Screenshot 2024-12-20 at 19 33 51

After
Screenshot 2024-12-20 at 19 34 10

@jankowiakdawid jankowiakdawid requested a review from a team as a code owner December 20, 2024 18:34
ittaishay
ittaishay previously approved these changes Dec 20, 2024
tjuanitas
tjuanitas previously approved these changes Dec 20, 2024
Copy link
Contributor

@tjuanitas tjuanitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good but i'm wondering how formatting issues are passing?

src/elements/content-sidebar/SidebarPanels.js Outdated Show resolved Hide resolved
@jankowiakdawid jankowiakdawid dismissed stale reviews from tjuanitas and ittaishay via c80a39f December 22, 2024 11:18
@jankowiakdawid jankowiakdawid force-pushed the fix-avatar-image-in-ai-sidebar branch 2 times, most recently from c80a39f to 8505ad8 Compare December 22, 2024 11:23
kajarosz
kajarosz previously approved these changes Dec 23, 2024
tjuanitas
tjuanitas previously approved these changes Dec 27, 2024
@karolinaru karolinaru force-pushed the fix-avatar-image-in-ai-sidebar branch from 8505ad8 to 9afa433 Compare December 31, 2024 12:09
rafalmaksymiuk
rafalmaksymiuk previously approved these changes Dec 31, 2024
bfoxx1906
bfoxx1906 previously approved these changes Jan 2, 2025
@@ -266,7 +269,7 @@ class SidebarPanels extends React.Component<Props, State> {
hasSidebarInitialized={isInitialized}
ref={this.boxAISidebar}
startMarkName={MARK_NAME_JS_LOADING_BOXAI}
userInfo={{name: currentUser?.name, avatarUrl: currentUser?.avatar_url}}
userInfo={{ name: currentUser?.name, avatarURL: currentUser?.avatar_url }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like there's a spacing issue

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It seems that earlier we must have merged something with incorrect formatting, as this is already the second time we're fixing spacing and commas

@mergify mergify bot merged commit 91ba714 into box:master Jan 2, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants