feat(boxai-sidebar): Fix Clear conversation icon #3818
+73
−53
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karolinaru
reviewed
Dec 23, 2024
kkuliczkowski-box
force-pushed
the
box-ai-clear-conversation
branch
from
297d949 to
364f9f6
Compare
karolinaru
approved these changes
Dec 27, 2024
marcoartaviaq
requested changes
Dec 27, 2024
| onClick={onClearAction} | ||
| size="x-small" | ||
| /> | ||
| { isResetChatEnabled && |
There was a problem hiding this comment.
🔧 I suggest that instead of duplicating this component, please abstract the implementation from the shared feature box ai content answers, and pass the additional props and expose it through the main index file.
That way, if we want in the future to modify the icon, text or tooltip we have only 1 source of truth for them
tjuanitas
reviewed
Dec 27, 2024
There was a problem hiding this comment.
i've been noticing a lot of formatting changes are happening in recent PRs. are you pushing with a --no-verify? there's a git husky hook that should be formatting the staged files with prettier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fixed icon size and added tooltip with Clear conversation text to the Clear button in BoxAISidebar header.
Screenshots
Screen.Recording.2024-12-23.at.14.59.51.mov