Fixed selected episode jumping to the top of the list after playing an item #481
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2013 21:01
… item (issue boxeehacks#371) Additionally reworked the code that searches for the last unwatched episode for better performance and readability.
|
Please ignore the other commit (d794ac4), it's the first time I use git and didn't realize the pull request would include both commits I had made on my fork. Hopefully you can cherry-pick the commits to merge... |
|
I hope this gets used in the next release |
|
this should be merged, it fixes core functionality |
|
Thanks for this. The jumping to the top was bothering my wife. lol |
|
You should also be able to rebase this commit, so you only got your own commit in this PR. Hope git doesn't give any troubles. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes the issue described at #371
Additionally I've reworked from scratch the code that searches for the last unwatched episode, which is now simpler and faster (since it breaks the loop as soon as the first watched episode is found). I've tested this code with as many corner cases as I could think off and it worked flawlessly.