Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SETUP] Set PHP 8.2 as default, add PHP 8.3 support #415

Merged
merged 1 commit into from
Jan 23, 2024
Merged

[SETUP] Set PHP 8.2 as default, add PHP 8.3 support #415

merged 1 commit into from
Jan 23, 2024

Conversation

jonny-bull
Copy link
Contributor

@jonny-bull jonny-bull commented Dec 7, 2023

  • sets PHP 8.2 as the default version of PHP
  • uses the twentytwentyfour theme by default
  • initial PHP 8.3 support
  • switches to positional arguments for setting network name, styleguide directory, PHP version and project name
  • removes PHP 8.0 as it went out of support on 26th November 2023
  • updates WordPress CLI image
  • updates Composer and adjacent packages
  • PHPStan support

The Dictator installation step includes warnings. This is a separate package to be updated to PHP 8.2

PHP 8.3 is not supported by Travis, inpsyde/wonolog or wecodemore/wordpress-early-hook at time of writing. Travis setup will be required as PHP 8.3 support is adopted.

Memcached currently throws warnings. A fix has been added for this: Automattic/wp-memcached#149. The fix should be in the next release

PHPUnit 10 currently throws errors related to PHPUnit\Util\Test::parseTestMethodAnnotations. This is deprecated in PHPUnit 10 but is used by PHPUnit Polyfills 2.0. Efforts are underway to resolve this: Yoast/PHPUnit-Polyfills#128

Composer packages are updated to PHP 8.1 to provide backwards compatibility.

@jonny-bull jonny-bull force-pushed the php-82 branch 15 times, most recently from 44c5700 to e95ad0d Compare December 14, 2023 11:28
@jonny-bull jonny-bull force-pushed the php-82 branch 3 times, most recently from 2fbe14c to 1e633da Compare January 2, 2024 10:32
@jonny-bull jonny-bull marked this pull request as ready for review January 2, 2024 11:58
@jdamner jdamner merged commit b10ea2f into main Jan 23, 2024
2 checks passed
@jdamner jdamner deleted the php-82 branch April 26, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants