Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

back-end: Measure products #1537

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

back-end: Measure products #1537

wants to merge 13 commits into from

Conversation

pylipp
Copy link
Contributor

@pylipp pylipp commented Sep 13, 2024

No description provided.

@pylipp
Copy link
Contributor Author

pylipp commented Sep 13, 2024

EPIC: Products with measure (continuous size)

@codecov Codecov
Copy link

codecov bot commented Sep 13, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.92%. Comparing base (725c969) to head (9f92002).

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #1537      +/-   ##
==========================================
+ Coverage   85.87%   85.92%   +0.05%     
==========================================
  Files         229      230       +1     
  Lines       21754    21819      +65     
  Branches     1940     1947       +7     
==========================================
+ Hits        18682    18749      +67     
+ Misses       3036     3034       -2     
  Partials       36       36
Flag Coverage Δ
backend 99.09% <ø> (+0.05%) ⬆️
frontend 82.70% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pylipp pylipp force-pushed the measure-products-data-and-api branch from babe87d to 65f7540 Compare September 17, 2024 11:53
@pylipp pylipp force-pushed the measure-products-data-and-api branch 2 times, most recently from 6f159d7 to 2af0920 Compare September 26, 2024 09:50
HaGuesto
HaGuesto approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@HaGuesto HaGuesto left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

code review passed

functional review

will be coming when we have the mutations for boxes updated.

FYI:
FE: since sizeId can be null now we need to check validation in form handlers.

back/boxtribute_server/business_logic/statistics/crud.py Outdated Show resolved Hide resolved
back/boxtribute_server/business_logic/statistics/sql.py Show resolved Hide resolved
@pylipp pylipp marked this pull request as ready for review September 30, 2024 14:52
@pylipp
Copy link
Contributor Author

pylipp commented Sep 30, 2024 •
edited
Loading

FE: since sizeId can be null now we need to check validation in form handlers.

@HaGuesto possible related: build-front breaks

EDIT: tried to fix in c038ab3

@pylipp pylipp force-pushed the measure-products-data-and-api branch 2 times, most recently from 7505e48 to c038ab3 Compare October 1, 2024 08:41
@pylipp pylipp force-pushed the measure-products-data-and-api branch from c038ab3 to 9f92002 Compare October 1, 2024 20:57
@pylipp pylipp mentioned this pull request Oct 3, 2024
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaGuesto HaGuesto HaGuesto approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pylipp @HaGuesto