Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PHP Fixer upgrade #530

Closed
wants to merge 2 commits into from
Closed

PHP Fixer upgrade #530

wants to merge 2 commits into from

Conversation

jamescrowley
Copy link
Contributor

@jamescrowley jamescrowley commented Feb 18, 2023 •
edited
Loading

This was warning CI on the linting step now, so adding upgrade to the library.

@jamescrowley
Upgrade PHP fixer
c2e7ee1 
as it's failing the build
@jamescrowley jamescrowley deleted the phpfixer branch February 18, 2023 18:15
@jamescrowley jamescrowley restored the phpfixer branch February 18, 2023 18:17
@jamescrowley jamescrowley reopened this Feb 18, 2023
HaGuesto
HaGuesto requested changes Feb 24, 2023
View reviewed changes
Copy link
Member

@HaGuesto HaGuesto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jamescrowley can you check why the circleCI checks fail?

@jamescrowley
Copy link
Contributor Author

I think it might be a mismatch in PHP versions as I’m running 8.x locally. I’ll take a look

@jamescrowley
Copy link
Contributor Author

Closing as this was done in 5fe2e8f

@jamescrowley jamescrowley deleted the phpfixer branch July 20, 2024 01:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HaGuesto HaGuesto HaGuesto requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jamescrowley @HaGuesto