Fix/#2 status codes #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Update changelog for 1.2.0 * feat(security): prevent secrets from leaking to source control (boyney123#59) * feat(security): prevent secrets from leaking to source control * chore: update lint-staged pacakgeto use v9 * fix: update versions * fix(security): add secrets baseline
Codecov Report
@@ Coverage Diff @@
## master #65 +/- ##
==========================================
+ Coverage 94.77% 94.84% +0.07%
==========================================
Files 20 20
Lines 287 291 +4
Branches 55 55
==========================================
+ Hits 272 276 +4
Misses 15 15 |
|
This is great @zecarrera 🙏 Thanks for the contribution, I will work to get a release out |
boyney123
added a commit
that referenced
this pull request
Aug 13, 2019
* Update changelog for 1.2.0 * Fix/#2 status codes (#65) * 1.2.0 (#62) * Update changelog for 1.2.0 * feat(security): prevent secrets from leaking to source control (#59) * feat(security): prevent secrets from leaking to source control * chore: update lint-staged pacakgeto use v9 * fix: update versions * fix(security): add secrets baseline * 🚧 Added two extra status codes * ✅ Unit checks now validates options groups * 🚧 Label is only visible as a label attribute * Update changelog for 1.2.1 * fix(security): clean up markdown (#64) * Update changelog for 1.2.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Issue #2 Add More Status Codes
Why:
Increases number of options given when adding a route
How:
Added Status Codes 503 and 504.
Added optgroup to dropdown selector to split up different types
Checklist:
List had already been increased since the issue was raised, so decided just to verify which other codes are amongst the most frequent ones and then decided to add 503 and 504. Also followed the suggestion made in the previous PR that was closed, where the optgroup option was mentioned.