Adds xxHash64 plus extras #10
Merged
+1,058
−111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
boytertesting
bot
added
L/size
boytertesting
bot
added
M/complexity
|
Very nice. Merged. Ill look into cutting a release... probably next week when I have some time. Thanks so much for this. Makes me want to go finish the hashdeep stuff thats missing including the verification. |
|
Nice, thanks! Yeah, verification would be good... I mean, you've got the direction traversal and hashing obviously so it feels like it shouldn't be too much of a next step for verification but... famous last words 😉 |
|
Thankfully it does not look too hard. Although there is some things to consider. I have created that issue to start discussing this. I have the SQLite output format working as well which should be useful for this as well. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds:
test-all.shNote:
Might be able to actually drop some of the third party packages etc for stdlib ones now... specifically SHA3 etc.