Turn into module #22
Merged
Turn into module #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikku
requested review from
a team,
marstamm and
smbea
and removed request for
a team
barmac
reviewed
Dec 14, 2023
barmac
reviewed
Dec 14, 2023
* use variable expansion rather than Function#apply
nikku
force-pushed
the
turn-into-modules
branch
from
9b00933 to
ded4518
Compare
|
Updated the PR according to your comments @barmac. |
barmac
approved these changes
Dec 14, 2023
|
I verified the following works 🎉 <html>
<head>
</head>
<body>
<script type="module">
import intersect from 'https://unpkg.com/path-intersection?module';
var path0 = [ [ 'M', 0, 0 ], [ 'L', 100, 100 ] ];
var path1 = 'M0,100L100,0';
const intersection = intersect(path0, path1);
// [ { x: ..., y: ..., segment1: ..., segment2: ... }, ... ]
console.log(intersection);
</script>
</body>
</html> |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to consume the library as an ES module.
If we had this, then we could likely do the following: