Fix/detect connection outages #29
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Sh*t, tests broken, likely because of the immediate ping, I forgot to |
…sTransport` doesn't connect to Redis within the unit test
…ort` doesn't connect to Redis within the unit test
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #29 +/- ##
===========================================
Coverage 100.00% 100.00%
Complexity 141 141
===========================================
Files 25 25
Lines 409 411 +2
===========================================
+ Hits 409 411 +2 ☔ View full report in Codecov by Sentry. |
|
Tests fixed! 🎉 |
|
Hi Ben, It seems that But I guess this PR deserves to be merged 💪 Thanks, Mika |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaces #28 in a safer/cleaner way, following advices from clue/reactphp-redis#142 (comment)
What it does:
ping_intervalis positive, immediately ping connection before$transport->subscribe()is invoked. Reduces the risk of starting the hub with a broken redis linkunsubscribeevent and trigger a hub crash so that its supervisor can handle its respawn. I initially thought thatunsubscribewouldn't be safe (like a subscriber just closing the connection) but it looks it would only be triggered in the case of a lost connection, since Freddie never calls$client->unsubscribe().cc @misaert:
With both
ping_intervalenabled and that small addition, the EventSource was always able to recover its connection to the hub once Redis was back on again (during my tests). Can you please give this one a try?Thanks @SimonFrings for the tip!