Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add API call details when signature matches #144

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tsmolka
Copy link
Contributor

@tsmolka tsmolka commented Nov 2, 2015

As you know Cuckoo offers (since 1.2 or 1.3 I believe) Signature.add_match() method for marking process and data (e.g. API call) that triggered the signature. In practice this sometimes gives pretty detailed background on why the signature was actually triggered.

Is there any reason why there are currently no signatures using this helper method? In many cases the change is quite trivial without negative impact.

Sample output when antiav_avast_libs matches on sample 0598ee3e06c681d7f9e05d83bb7ea422.
screen shot 11-02-15 18-06-26

Commit a625e90 updates just first three signatures, the rest (at least where change is trivial) would follow.

@tsmolka tsmolka changed the title Added API call details when signature matches Add API call details when signature matches Nov 2, 2015
@brad-sp
Copy link
Owner

brad-sp commented Nov 3, 2015

The signature API was updated at the same time of a mass conversion of all signatures to use the new API -- I didn't (and don't) feel that it really contributed anything useful to the majority of signatures other than adding more clutter to the interface. More important was fixing the numerous errors in many of the signatures that still weren't fixed during that mass conversion.

I'm of the feeling that if a signature is to provide additional information, it should involve some significant processing (like the Dyre C2 display) vs just adding standard tables of API logs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants