fix preprocessor logic with HAVE_STAT #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The _WIN32 check is inside a preprocessor branch that has already checked that _WIN32 is not defined. On the other hand, if HAVE_STAT is not available, then the function does not have an alternative method to check that a file exists. The not-apple-not-windows branch should have stat() available, so this is a very unlikely situation.
createyourpersonalaccount
force-pushed
the
fix-cpp-logic
branch
from
35a3ea4 to
2f10ccd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The _WIN32 check is inside a preprocessor branch that has already
checked that _WIN32 is not defined.
On the other hand, if HAVE_STAT is not available, then the function
does not have an alternative method to check that a file exists. The
not-apple-not-windows branch should have stat() available, so this is
a very unlikely situation.