Skip to content

Add routeProps param to Location.toRoute() #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

Konstantinov-Innokentii

In case, when location objects and matching components are stored in array of objects like this:
let routes = [{location: Location, component: Component}, ...]

and used in this way:

<Switch location={createLocation(this.props.window.path+this.props.window.search)}>
    {routes.map(r => r.location.toRoute({
        render: (props) => <r.component {...props} />,
        invalid: NotFound,
    }))}
</Switch>

I get Warning "Each child in an array or iterator should have a unique "key" prop". To avoid it I should pass key prop to Route. For this purpose I added routeProps param to Location.toRoute().
Usage is:

<Switch location={createLocation(this.props.window.path+this.props.window.search)}>
    {routes.map(r => r.location.toRoute({
        render: (props) => <r.component {...props}/>,
        invalid: NotFound,
    },  true, {key: this.props.uuid}, false, false))}
</Switch>

@ptrobert
Copy link

ptrobert commented Apr 15, 2019

In case, when location objects and matching components are stored in array of objects like this:
let routes = [{location: Location, component: Component}, ...]

and used in this way:

<Switch location={createLocation(this.props.window.path+this.props.window.search)}>
    {routes.map(r => r.location.toRoute({
        render: (props) => <r.component {...props} />,
        invalid: NotFound,
    }))}
</Switch>

I get Warning "Each child in an array or iterator should have a unique "key" prop". To avoid it I should pass key prop to Route. For this purpose I added routeProps param to Location.toRoute().
Usage is:

<Switch location={createLocation(this.props.window.path+this.props.window.search)}>
    {routes.map(r => r.location.toRoute({
        render: (props) => <r.component {...props}/>,
        invalid: NotFound,
    },  true, {key: this.props.uuid}, false, false))}
</Switch>

Facing the same issue, Please merge this quickly

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants