Issue #971 Make local copy of speeking_module to ensure it can be tested for NULL #972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n be tested for NULL
|
Please merge the test for NULL with the test above, no need to have two of them :) |
|
thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
speakthread can change thespeeking_moduleto NULL while we are in this function. So even thoughspeeking_moduleis tested for NULL, this is not good enough in a multi-threading environment.This change grabs a local copy of
speeking_moduleand then tests that for NULL so that even if a thread context switch were to occur andspeeking_moduleis set to NULL, the local copy will remain stable and usable.