Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Method to reference channels for Issue #619 #630

Closed
wants to merge 2 commits into from

Conversation

kkashiva
Copy link

added method signature and implementation comments to DataFilter.java

Creating WIP draft pull request for the issue #619

Next: complete implementation for java package and then do the same for other language packages.

@Andrey1994
Copy link
Member

Andrey1994 commented May 27, 2023

Hi and thanks for working on it.

Java part looks fine.

You can add it to one of examples we already have, I do not think that we need a new one.
Downsampling should be ok - https://github.com/brainflow-dev/brainflow/blob/master/java_package/brainflow/src/main/java/brainflow/examples/Downsampling.java just keep in mind that this example also used as a code sample at BrainFlow Docs, so write some comments there for people who use it as a reference.

@Andrey1994
Copy link
Member

no activiti in PR, closing

@Andrey1994 Andrey1994 closed this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants