Reduce the number of extras. #54
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I agree. The default can be light weight with frequently used dependencies. |
|
The recent updates to the build system include precompiling wheels for raspberry pi, so we don't have to worry so much about small package footprint anymore, right? If that's fixed, I'm definitely in favor of this change |
atspaeth
approved these changes
Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Mostly wanted to open this up for discussion, since I think it would simplify things a little.
Proposing we include all extra dependencies in the
pip install braingeneersinstall by default, and only separate:ml(large and time-consuming install)hengenlab(not as well-maintained/reliable, because it's a personal lab's python library)dev(all test and documentation dependencies)Also: added the maintainers section and got rid of the bogus boilerplate email address for the author section.