Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed a common_utils bug when using file_list with no matching files #61

Merged
merged 11 commits into from
Dec 14, 2023

Conversation

davidparks21
Copy link
Contributor

Fixed a reasonably small issue with common_utils.file_list that threw an exception when no files matched. Added test cases (written by GPT, run ok, look ok, mocked S3 calls).

@codecov-commenter
Copy link

Welcome to Codecov 🎉

Once merged to your default branch, Codecov will compare your coverage reports and display the results in this comment.

Thanks for integrating Codecov - We've got you covered ☂️

Copy link
Member

@DailyDreaming DailyDreaming left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@DailyDreaming DailyDreaming merged commit a462441 into master Dec 14, 2023
19 checks passed
@DailyDreaming DailyDreaming deleted the dp-bug-common-utils branch December 14, 2023 21:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants