Map2 support varargs functions #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minor updated map2 to support vararg functions minor
davidparks21
force-pushed
the
map2-support-varargs-functions
branch
from
040a47e to
feef8fc
Compare
|
I fixed the bug, this branch is ready to merge. This PR is just small improvements to map2 so that it supports functions with **kwargs definitions such as cached_load_data uses now. @DailyDreaming |
DailyDreaming
approved these changes
May 22, 2024
Merged
atspaeth
pushed a commit
that referenced
this pull request
Jun 7, 2024
* updated map2 to support vararg functions * updated map2 to support vararg functions minor updated map2 to support vararg functions minor * Fixed new bug found and added unit tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The map2 function didn't support functions defined with keyword varargs, such as:
def f(a, b, **kwargs):
pass
This is fixed by adding a kwargs option along with function docs showing an example.