Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update minimum cellfinder and segmentation #62

Merged
merged 1 commit into from
Aug 8, 2024

Conversation

alessandrofelder
Copy link
Member

@alessandrofelder alessandrofelder commented Aug 7, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?

New versions of cellfinder and brainglobe-segmentation have a bugfix (to avoid dependency versions being incompatible with numpy>=2)

What does this PR do?

Pins cellfinder and segmentation to newest versions.

References

\

How has this PR been tested?

\

Is this a breaking change?

no

Does this PR require an update to the documentation?

We should maybe note somewhere that brainglobe does not support numpy yet?

Checklist:

  • [ \ ] The code has been tested locally
  • [ \ ] Tests have been added to cover all new functionality (unit & integration)
  • [ \ ] The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@alessandrofelder alessandrofelder marked this pull request as ready for review August 7, 2024 17:23
Copy link

codecov bot commented Aug 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 60.00%. Comparing base (4dc59bd) to head (e7094d7).

Additional details and impacted files
@@           Coverage Diff           @@
##             main      #62   +/-   ##
=======================================
  Coverage   60.00%   60.00%           
=======================================
  Files           1        1           
  Lines           5        5           
=======================================
  Hits            3        3           
  Misses          2        2           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@alessandrofelder alessandrofelder requested a review from a team August 7, 2024 17:43
@IgorTatarnikov IgorTatarnikov merged commit 98e00c4 into main Aug 8, 2024
13 checks passed
@IgorTatarnikov IgorTatarnikov deleted the pin-to-latest-deps branch August 8, 2024 08:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants