Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor to use ImageIOLoadException from brainglobe_utils #186

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

K-Meech
Copy link
Contributor

@K-Meech K-Meech commented Mar 21, 2024

Description

What is this PR

  • Bug fix
  • Addition of a new feature
  • Other

Why is this PR needed?
brainreg currently has a LoadFileException class that should be refactored into brainglobe-utils, and imported from there

What does this PR do?
This PR uses the refactored ImageIOLoadException from brainglobe-utils

References

For #180
Related to refactoring in brainglobe/brainglobe-utils#59

How has this PR been tested?

Tests were updated, and all pass locally.

Is this a breaking change?

No

Does this PR require an update to the documentation?

No

Checklist:

  • The code has been tested locally
  • Tests have been added to cover all new functionality (unit & integration)
  • The documentation has been updated to reflect any changes
  • The code has been formatted with pre-commit

@willGraham01
Copy link
Contributor

This will need to wait for a new release of brainglobe-utils after brainglobe/brainglobe-utils#59 (comment) is merged in for the CI to pass right?

In which case, you'll want to update the pyproject.toml to pin the new version of brainglobe-utils as a minimum requirement (once it has been released of course). Then the CI should pass after being forced to fetch the new version.

Copy link
Member

@alessandrofelder alessandrofelder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lovely!

@alessandrofelder alessandrofelder merged commit 541ff9c into main Mar 25, 2024
12 checks passed
@alessandrofelder alessandrofelder deleted the refactor_LoadFileException branch March 25, 2024 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants