-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Introduce Tabs component #2678
base: master
Are you sure you want to change the base?
Conversation
This commit changes styling of active indicator as well. That's because of Transition component overwriting style attribute.
thx @azajac-brl , could you please add to the list:
as for
please take a look here: and example: style-guide/src/components/icons/Icon.tsx Line 522 in 44befb4
|
hey @azajac-brl, when it comes to accessibility and keyboard support. I know that @katarzynatobis and @bartoszlorek were working on similar support for some segmented-like/tab component in the app. Maybe that PR would be a good reference for applying same support here? |
Thanks for letting me know! I'll reach out to them about that! :) |
Missing:
ActiveIndicator