-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update braintree_android to 4.33.0 #424
Conversation
Seeing some failures while running Would appreciate any guidance around what else needs to be updated with this version bump! |
@khushboo18 which Rake task are you running and seeing errors for? |
@sshropshire I'm just trying to run |
I just approved and ran CI on this branch and |
@jaxdesmarais thanks! This is what some of the failure look like -
And these same failures are showing on master so maybe something wrong with my local env? |
@khushboo18 I'm not seeing this error on my machine, but I can see how this error may be thrown I'm surprised this hasn't occurred before. We do have some classes in our Core SDK annotated with Which version of Android Studio are you using? And also what version of the JDK are you using to build? |
@sshropshire I'm not using Android Studio for this, I was just running it from my terminal.
Will run it on android studio and update Update: same failure on android studio as well, version |
Ok I'm using the same |
Gave that a try, same errors with JDK version "17.0.7". |
@khushboo18 I can give it a 👍 once CI passes. We can wait on the other 👍 and merge. |
Thank you for your contribution to Braintree.
Summary of changes
Checklist
Authors