Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make PaymentMethodClient Methods Public #433

Merged
merged 5 commits into from
Aug 23, 2023
Merged

Make PaymentMethodClient Methods Public #433

merged 5 commits into from
Aug 23, 2023

Conversation

sarahkoop
Copy link
Contributor

@sarahkoop sarahkoop commented Aug 23, 2023 •
edited
Loading

Summary of changes

Checklist

  • Added a changelog entry

Authors

@sarahkoop sarahkoop requested a review from a team as a code owner August 23, 2023 14:38
sshropshire
sshropshire approved these changes Aug 23, 2023
View reviewed changes
Copy link
Contributor

@sshropshire sshropshire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌊 great call! Would love to get this in Core some day.

sshropshire
sshropshire reviewed Aug 23, 2023
View reviewed changes
Drop-In/src/androidTest/java/com/braintreepayments/api/AddCardFragmentUITest.kt

@Before
fun setup() {
args.putParcelable("EXTRA_DROP_IN_REQUEST", DropInRequest())
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for this 🙌

@sarahkoop sarahkoop merged commit a75d304 into master Aug 23, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sshropshire sshropshire sshropshire approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

4.x not possible to get list if payment methods (list of nonces)
3 participants
@sarahkoop @jaxdesmarais @sshropshire