Upgrade to Android 14 #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sshropshire
approved these changes
Sep 18, 2023
sshropshire
reviewed
Sep 18, 2023
Drop-In/build.gradle
Outdated
| disable 'InvalidPackage' // The Cardinal SDK is referencing the `javax.naming` package but it is unavailable | ||
| // RestrictedApi - Accessing Braintree Core SDK non-public methods | ||
| // InvalidPackage - The Cardinal SDK is referencing the `javax.naming` package but it is unavailable | ||
| disable 'RestrictedApi', 'InvalidPackage' |
There was a problem hiding this comment.
random: I wonder if Cardinal actually needs javax.naming to work
There was a problem hiding this comment.
Actually looks like they don't use it anymore or it's not causing a lint error - removed that option 👍
jaxdesmarais
approved these changes
Sep 18, 2023
Co-authored-by: Jax DesMarais-Leder <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Checklist
Authors