Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add customUrlScheme Property to DropInRequest #439

Merged
merged 10 commits into from
Sep 19, 2023
Merged

Add customUrlScheme Property to DropInRequest #439

merged 10 commits into from
Sep 19, 2023

Conversation

sshropshire
Copy link
Contributor

Summary of changes

  • Add customUrlScheme property to DropInRequest to allow custom URL schemes to be set for browser-based flows
  • This will provide a workaround to merchants who have uppercase characters in their applicationId

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire requested a review from a team as a code owner September 18, 2023 21:30
jaxdesmarais
jaxdesmarais approved these changes Sep 19, 2023
View reviewed changes
CHANGELOG.md Outdated Show resolved Hide resolved
@sshropshire @jaxdesmarais
Update CHANGELOG.md
0112260 
Co-authored-by: Jax DesMarais-Leder <[email protected]>
@sshropshire sshropshire merged commit 611d842 into master Sep 19, 2023
1 check passed
@sshropshire sshropshire deleted the spike_drop_in_custom_url_scheme branch September 19, 2023 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

@sarahkoop sarahkoop sarahkoop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sshropshire @jaxdesmarais @sarahkoop