Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migration Guide Custom URL Scheme #440

Merged
merged 3 commits into from
Sep 19, 2023

Conversation

sshropshire
Copy link
Contributor

Summary of changes

  • Add migration guide entry to explain custom URL scheme override through DropInRequest

Checklist

- [ ] Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire requested a review from a team as a code owner September 19, 2023 15:57
@@ -250,3 +250,30 @@ Kotlin:

DropIn handles browser switching internally. Specifying an `<intent-filter />` in `AndroidManifest.xml` is no longer required. Any payment method that requires a browser switch will work automatically.

On the other hand, there are some scenarios that will require you to set a custom URL scheme for browser switch deep linking. For example, if your `applicationId` contains uppercase letters, you will need to override the default deep link configuration set by the DropIn library.

Internally we use a manifest placeholder to support deep linking into `DropInActivity`. You can override the deep link intent filter for `DropInActivity` by placing the following xml snippet in your app's `AndroidManifest.xml`:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also add a line like: If you are not setting a custom URL scheme for deep linking, you do not need to add an intent filter to support Drop-in?

In case merchants see this an think they always need to add this to their manifest.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah I thought about adding another section for this to make it clear. Technically we say "no additional configuration required" in the first paragraph of this section, but it may not be prominent enough.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh true ok that's probably enough

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a ticket for adding this to the public dev docs?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ended up creating DTBTSDK-3020 for this.

@sshropshire sshropshire merged commit 6b23f12 into master Sep 19, 2023
1 check passed
@sshropshire sshropshire deleted the migration_guide_custom_url_scheme branch September 19, 2023 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants