Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v7 Beta] Create DropInLauncher #468

Open
wants to merge 20 commits into
base: v7_beta
Choose a base branch
from

Conversation

sshropshire
Copy link
Contributor

@sshropshire sshropshire commented Mar 27, 2024

Summary of changes

  • Replace DropInClient with DropInLauncher
  • Add DropInLauncherCallback to receive Activity result
  • Move fetchMostRecentPaymentMethod() to RecentPaymentMethodsClient

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@sshropshire sshropshire marked this pull request as ready for review April 3, 2024 17:02
@sshropshire sshropshire requested a review from a team as a code owner April 3, 2024 17:02
@@ -152,7 +187,8 @@ public void launchDropIn(View v) {
dropInRequest.setThreeDSecureRequest(demoThreeDSecureRequest());
}

dropInClient.launchDropIn(dropInRequest);
// TODO: make auth string a required DropInRequest constructor parameter
dropInLauncher.launchDropIn(authString, dropInRequest);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This reads a little odd to me since it's like the inverse of one another, not sure if something like this would make it feel less awward:

Suggested change
dropInLauncher.launchDropIn(authString, dropInRequest);
dropInLauncher.start(authString, dropInRequest);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah def that's a good call. It aligns nicely with our SDKs as a whole. I'll do this in a separate commit to make sure all occurrences are renamed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants