-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[v7 Beta] Create DropInLauncher #468
base: v7_beta
Are you sure you want to change the base?
Conversation
This reverts commit e0658c3.
@@ -152,7 +187,8 @@ public void launchDropIn(View v) { | |||
dropInRequest.setThreeDSecureRequest(demoThreeDSecureRequest()); | |||
} | |||
|
|||
dropInClient.launchDropIn(dropInRequest); | |||
// TODO: make auth string a required DropInRequest constructor parameter | |||
dropInLauncher.launchDropIn(authString, dropInRequest); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This reads a little odd to me since it's like the inverse of one another, not sure if something like this would make it feel less awward:
dropInLauncher.launchDropIn(authString, dropInRequest); | |
dropInLauncher.start(authString, dropInRequest); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yeah def that's a good call. It aligns nicely with our SDKs as a whole. I'll do this in a separate commit to make sure all occurrences are renamed.
Summary of changes
DropInClient
withDropInLauncher
DropInLauncherCallback
to receive Activity resultfetchMostRecentPaymentMethod()
toRecentPaymentMethodsClient
Checklist
Authors