[V7] Update BTLocalPaymentRequest
#1447
Conversation
| /// - isShippingAddressRequired: Indicates whether or not the payment needs to be shipped. For digital goods, this should be `false`. Defaults to `false`. | ||
| /// - bic: Optional: Bank Identification Code of the customer (specific to iDEAL transactions). | ||
| public init( | ||
| paymentType: String? = nil, |
There was a problem hiding this comment.
is everything really optional?
There was a problem hiding this comment.
Thanks for asking, i've updated it. paymentType, amount and currencyCode are required for all LPMs, others depend on the type.
As docs says: paymentTypeCountryCode is required for payment methods with multiple potential country codes, otherwise it will use the countryCode (reference)
| let surname: String? | ||
| let phone: String? | ||
| var isShippingAddressRequired: Bool = false | ||
| let bic: String? | ||
|
|
||
| public weak var localPaymentFlowDelegate: BTLocalPaymentRequestDelegate? |
There was a problem hiding this comment.
In the case of delegates, do we prefer using dot syntax or requiring them in the init? Apple uses dot syntax
There was a problem hiding this comment.
Let's follow apple's lead and use the dot syntax!
| /// - phone: Optional: Phone number of the customer. | ||
| /// - isShippingAddressRequired: Indicates whether or not the payment needs to be shipped. For digital goods, this should be `false`. Defaults to `false`. | ||
| /// - bic: Optional: Bank Identification Code of the customer (specific to iDEAL transactions). | ||
| public init( |
There was a problem hiding this comment.
Take it or leave it - do we want to alphabetize these?
| let surname: String? | ||
| let phone: String? | ||
| var isShippingAddressRequired: Bool = false | ||
| let bic: String? | ||
|
|
||
| public weak var localPaymentFlowDelegate: BTLocalPaymentRequestDelegate? |
There was a problem hiding this comment.
Let's follow apple's lead and use the dot syntax!
|
|
||
| /// Creates a LocalPaymentRequest | ||
| /// - Parameters: | ||
| /// - paymentType: The type of payment. |
There was a problem hiding this comment.
Are these listed anywhere? If so can we link to the doc for it?
There was a problem hiding this comment.
Updated: 99b8064
Summary of changes
Docstrings:
Checklist
Authors