Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update heroku server endpoints #1449

Merged
merged 3 commits into from
Nov 4, 2024
Merged

Update heroku server endpoints #1449

merged 3 commits into from
Nov 4, 2024

Conversation

warmkesselj
Copy link
Contributor

@warmkesselj warmkesselj commented Oct 30, 2024 •
edited
Loading

Summary of changes

Updating the url endpoints for the new Heroku apps ruby server.

@warmkesselj warmkesselj requested a review from a team as a code owner October 30, 2024 23:42
@warmkesselj warmkesselj changed the title update the environmentURL to point to the new heroku app servers Update heroku server endpoints Oct 30, 2024
jaxdesmarais
jaxdesmarais reviewed Oct 31, 2024
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we able to add a description to this PR with why we are making this change? I also assume we've tested all the flows to ensure things are still working as expected in the demo app?

@warmkesselj
Copy link
Contributor Author

Are we able to add a description to this PR with why we are making this change? I also assume we've tested all the flows to ensure things are still working as expected in the demo app?

I've run through the demo app but would be nice to have a second pair of eyes run through as well.

jaxdesmarais
jaxdesmarais approved these changes Nov 1, 2024
View reviewed changes
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ran through the flows as well in production and sandbox and both appear to be working as expected.

@warmkesselj warmkesselj merged commit 273e8a9 into main Nov 4, 2024
7 of 8 checks passed
@warmkesselj warmkesselj deleted the braintree-demo-merchant branch November 4, 2024 22:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scannillo scannillo scannillo approved these changes

@jaxdesmarais jaxdesmarais jaxdesmarais approved these changes

Assignees
No one assigned
Labels
do not merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@warmkesselj @jaxdesmarais @scannillo