Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update BTPayPalRequest with App Switch Properties #1465

Conversation

agedd
Copy link
Contributor

@agedd agedd commented Nov 14, 2024

Summary of changes

  • Update BTPayPalRequest with app-switch properties, enablePayPalAppSwitch and userAuthenticationEmail
  • Remove these properties from BTPayPalVaultRequest
  • Add init to BTPayPalCheckoutRequest with these properties
  • Tested and verified app switch flow for vaulting works as expected (the checkout flow is not yet expected to work)

Checklist

  • Added a changelog entry

Authors

List GitHub usernames for everyone who contributed to this pull request.

@agedd agedd requested a review from a team as a code owner November 14, 2024 20:53
Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have the base branch as the feature branch. Lets also try not to have the internal ticket number in the branch name in the future.

@agedd agedd changed the base branch from main to app-switch-checkout-feature November 15, 2024 15:32
Copy link
Contributor

@richherrera richherrera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!!

Copy link
Contributor

@jaxdesmarais jaxdesmarais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀

@agedd agedd merged commit e9b5a7e into app-switch-checkout-feature Nov 22, 2024
8 checks passed
@agedd agedd deleted the dtmobiles-1183-update-`btpaypalrequest`-with-app-switch branch November 22, 2024 19:29
agedd added a commit that referenced this pull request Feb 20, 2025
* Update `BTPayPalRequest` with App Switch Properties (#1465)

* add initial commits for updating `BTPayPalRequest` with app switch properties

* add changelog.md entry

* address pr feedback

* cleanup

* cleanup doc string

* address pr feedback

* add app-switch support for one-time-checkout

* Revert "add app-switch support for one-time-checkout"

This reverts commit 26cfe78.

* add app-switch demo app support for one-time checkout flow (#1471)

* update parsing app switch url for 1-time checkout flow (#1500)

* Launch PayPal App For Checkout Flow (#1504)

* make changes to launch pp app for checkout flow

* address failing unit test

* address pr comments

* address pr feedback

* disable unit test

* clean up and address pr feedback

* clean up and re-add test/relevant errors

* fix warning

* address swift lint error

* ECS5 App Switch Feature Bug Fixes (#1512)

* add token param

* update parsing logic

* fix linkType bug

* remove token parameter as we expect gw to pass this in redirectURL

* pull in main changes

* address pr feedback

* fix spacing

* code cleanup

* more cleanup
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants