Add Contact Information request object #1469
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxdesmarais
approved these changes
Nov 22, 2024
| /// Phone number of the recipient | ||
| let recipientPhoneNumber: BTPayPalPhoneNumber? | ||
|
|
||
| public init(recipientEmail: String? = nil, recipientPhoneNumber: BTPayPalPhoneNumber? = nil) { |
There was a problem hiding this comment.
Lets add docstrings here instead of on the internal properties.
There was a problem hiding this comment.
Sure, updated: fcd5c15
agedd
reviewed
Nov 26, 2024
| XCTAssertEqual(internationalPhone, ["country_code": "US", "national_number": "123456789"]) | ||
| } | ||
|
|
||
| func testParametersWithConfiguration_whenContactInformationNotSet_doesNotSetPayerEmailInRequest() { |
There was a problem hiding this comment.
small nit: take it or leave it
Suggested change
| func testParametersWithConfiguration_whenContactInformationNotSet_doesNotSetPayerEmailInRequest() { | |
| func testParametersWithConfiguration_whenContactInformationNotSet_doesNotSetPayerEmailAndPhoneNumberInRequest() { |
agedd
approved these changes
Nov 26, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Introduces support for passing recipient contact information in the
BTPayPalCheckoutRequestBTContactInformationwas created to encapsulate the recipient's contact information for the order.Properties:
recipientEmailandrecipientPhoneNumbercontactInformationof typeBTContactInformation.contactInformation.recipientEmailandcontactInformation.recipientPhoneNumberare passed to thecreate_payment_resourceendpoint as therecipient_emailandinternational_phoneparameters when present.Note: When the new parameters (recipient_email and international_phone) are included, the gateway returns an error. I will follow up with updates once I gather more information or implement any necessary fixes.
Checklist
Authors