-
Notifications
You must be signed in to change notification settings - Fork 295
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Contact Information request object #1469
Merged
richherrera
merged 7 commits into
contact-information-feature
from
add-contact-info-request
Dec 2, 2024
Merged
Add Contact Information request object #1469
richherrera
merged 7 commits into
contact-information-feature
from
add-contact-info-request
Dec 2, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaxdesmarais
approved these changes
Nov 22, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One small docstring comment but overall looks great!
agedd
reviewed
Nov 26, 2024
UnitTests/BraintreePayPalTests/BTPayPalCheckoutRequest_Tests.swift
Outdated
Show resolved
Hide resolved
agedd
approved these changes
Nov 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 🚀 just left one small comment
…wift Co-authored-by: agedd <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
Introduces support for passing recipient contact information in the
BTPayPalCheckoutRequest
BTContactInformation
was created to encapsulate the recipient's contact information for the order.Properties:
recipientEmail
andrecipientPhoneNumber
contactInformation
of typeBTContactInformation
.contactInformation.recipientEmail
andcontactInformation.recipientPhoneNumber
are passed to thecreate_payment_resource
endpoint as therecipient_email
andinternational_phone
parameters when present.Note: When the new parameters (recipient_email and international_phone) are included, the gateway returns an error. I will follow up with updates once I gather more information or implement any necessary fixes.
Checklist
Authors