[V7] Add Encodable protocol for PayPal Checkout
#1491
Conversation
| if payPalRequest.requestBillingAgreement { | ||
| self.requestBillingAgreement = payPalRequest.requestBillingAgreement | ||
|
|
||
| if let billingAgreementDescription = payPalRequest.billingAgreementDescription { |
There was a problem hiding this comment.
Currently, this property belongs to class BTPayPalRequest. After changing its properties to internal in a previous PR, merchants can no longer access these properties, meaning there's no way to configure, for example, "billingAgreementDescription" when creating an instance of BTPayPalCheckoutRequest or BTPayPalVaultRequest. Do you think we should add the necessary properties to the init of BTPayPalCheckoutRequest or BTPayPalVaultRequest, or make the properties in BTPayPalRequest public again and remove BTPayPalRequest.init?
There was a problem hiding this comment.
That's a great catch, I don't think we want to make the properties on BTPayPalRequest public since that would allow merchants to use the dot syntax, which we would like to move away from. I think it makes sense to add the properties to BTPayPalCheckoutRequest or BTPayPalVaultRequest inits then pass them in the super.init? What do you think?
Summary of changes
postbodies used in the PayPal Checkout flow.Note: Since we have two different classes (
PayPalCheckoutRequestandPayPalVaultRequest) used inPayPalClient, it's currently not possible to useEncodableuntil the same implementation is done forPayPalVaultRequest. We tested the flow, but we need to complete taskDTMOBILES-1177to be able to useEncodable.Checklist
[ ] Added a changelog entryAuthors