Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added benchmark #19

Closed
wants to merge 1 commit into from
Closed

Added benchmark #19

wants to merge 1 commit into from

Conversation

ghost
Copy link

@ghost ghost commented Mar 30, 2020

The benchmark is used for testing BVH build and render times for various algorithms.

It downloads a Sponza model at configuration time, as opposed to storing it in the repository. That way, cloning the project doesn't take forever. Users who won't be running the benchmark won't want to wait for the long download time unless their running the benchmark.

The benchmark itself is made for comparing multiple build algorithms. It times the construction of the BVH as well as rendering time. The scheduler for the benchmark is multi-threaded, so it runs much faster than the scheduler in the examples. It also has progress updates for the tracing, which is nice for longer render times.

Initially, I had planned on running the "dummy" BVH build algorithm for a frame of reference. I ended up commenting it out because it was taking too long to render. I may still use the "dummy" build algorithm for integration testing later on, since it always produces a "known good" image.

Example output for a 100x100 pixel test:

Running benchmark for strategy 0
  Percent Completion: %100.00
Running benchmark for strategy 1
  Percent Completion: %100.00
Results:
              | Build Time (sec) | Render Time (sec) |
              |------------------|-------------------|
  Strategy 00 |   0.0080         |  12.3891          |
  Strategy 01 |   0.0725         |   0.0104          |

This PR addresses the second item in #14

The benchmark is used for testing BVH build and render
times for various algorithms.
@ghost
Copy link
Author

ghost commented Mar 30, 2020

Closing this, since I read #18 a little bit too late! Holding out for the bench marking system described there, as it sounds like it will be much more thought out. Sorry about that!

Moved to https://github.com/tay10r/Fast-BVH-benchmark

@ghost ghost closed this Mar 30, 2020
@brandonpelfrey
Copy link
Owner

I think this is a great starting point for #18, and we can use it as a jumping off point for more of what was described there. If you don't see any concerns, let's pull from your -benchmark repo. Sound good?

@ghost
Copy link
Author

ghost commented Mar 30, 2020

@brandonpelfrey If you insist! I'll reopen the PR.

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants