Make image names optional in Jetstream Maxtext module (GoogleCloudPla…

…tform#744) first commit
brandonroyal · Jul 18, 2024 · 1374b77 · 1374b77
1 parent 9bc7c2f
commit 1374b77
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 7 deletions.
diff --git a/modules/jetstream-maxtext-deployment/variables.tf b/modules/jetstream-maxtext-deployment/variables.tf
@@ -26,8 +26,8 @@ variable "project_id" {
 
 variable "maxengine_deployment_settings" {
   type = object({
-    maxengine_server_image      = string
-    jetstream_http_server_image = string
+    maxengine_server_image      = optional(string, "us-docker.pkg.dev/cloud-tpu-images/inference/maxengine-server:v0.2.2")
+    jetstream_http_server_image = optional(string, "us-docker.pkg.dev/cloud-tpu-images/inference/jetstream-http:v0.2.2")
 
     model_name              = string           // Name of your LLM (for example: "gemma-7b")
     parameters_path         = string           // Path to the paramters for your model

diff --git a/...ference-servers/jetstream/maxtext/single-host-inference/terraform/sample-terraform.tfvars b/...ference-servers/jetstream/maxtext/single-host-inference/terraform/sample-terraform.tfvars
@@ -1,7 +1,4 @@
 maxengine_deployment_settings = {
-  maxengine_server_image      = "us-docker.pkg.dev/cloud-tpu-images/inference/maxengine-server:v0.2.2"
-  jetstream_http_server_image = "us-docker.pkg.dev/cloud-tpu-images/inference/jetstream-http:v0.2.2"
-
   metrics_port            = 9100
   metrics_scrape_interval = 10
   accelerator_selectors = {

diff --git a/...examples/inference-servers/jetstream/maxtext/single-host-inference/terraform/variables.tf b/...examples/inference-servers/jetstream/maxtext/single-host-inference/terraform/variables.tf
@@ -51,8 +51,8 @@ variable "cluster_name" {
 
 variable "maxengine_deployment_settings" {
   type = object({
-    maxengine_server_image      = string
-    jetstream_http_server_image = string
+    maxengine_server_image      = optional(string)
+    jetstream_http_server_image = optional(string)
 
     model_name              = string           // Name of your LLM (for example: "gemma-7b")
     parameters_path         = string           // Path to the parameters for your model